In this talk I review several topics concerning the determination of quark masses by means of lattice QCD simulations, with particular focus on recently introduced techniques of non-perturbative renormalisation, the determination of heavy quark masses, and the proper quantification of the source of isospin breaking effects in the light quark sector.