In this paper we have two concerns. First we consider the features used to describe good quality learning actions and knowledge representations. Our second concern is the need to develop students' knowledge of how to act, during teachinglearning transactions, in order to generate good quality knowledge representations.There is a convergence of views, at a broad level, about the character of good quality knowledge. Although there are frequent specifications of the features of good quality learning these discussions mostly do not build on one another so that a coherent representation of such learning is built up. There is therefore a need to consider further the characteristics of learning that are regarded as being of good quality. For this purpose we set out a framework based around six dimensions of good quality knowledge, namely, extent, well-foundedness, structure, complexity, generativity, and variety of representational format. In the final section of the chapter we advance arguments that point to the need to attend to the state of students' and teachers' knowledge about how to act, in strategic cognitive and metacognitive ways, in order to generate good quality knowledge representations.