ERCC1 (excision repair cross complementation group 1) is a subunit of the nucleotide excision repair complex, which can perform DNA strand incision correction of DNA damage. Association studies on the ERCC1 polymorphisms (C8092A and T19007C) in cancer had shown conflicting results. We performed a meta-analysis from all eligible case-control studies to assess the purported associations. Overall, the 19007C allele (3 853 patients and 4 349 controls) showed no significant effect on cancer risk compared to 19007T allele (P ¼ 0.39, odds ratio (OR) ¼ 0.95; 95% confidence interval (CI) 0.85 -1.06, P heterogeneity ¼ 0.001) in all subjects. Meta-analysis under other genetic contrasts did not reveal any significant association of T19007C to cancer in all subjects, Caucasians and Asians. The 19007C allele (2 279 patients and 2 808 controls) showed no significant effect on lung cancer risk compared to 19007T allele (P ¼ 0.72, OR ¼ 0.94, 95% CI 0.69-1.29, P heterogeneity ¼ 0.0001) in all subjects. No significant effect of 8092A allele (3 865 patients and 3 750 controls) on cancer risk in all subjects (P ¼ 0.85, OR ¼ 1.01, 95% CI 0.94 -1.08, P heterogeneity ¼ 0.92) and in Caucasians and Asians compare to 8092C. No evidences of association of C8092A (501 patients and 620 controls) to squamous cell carcinoma were found. The accumulated evidence indicated ERCC1 T19007C and C8092A might not be risk factors for cancer. Significant betweenstudy heterogeneity existed in T19007C, which arose from a study showing significant protecting effect of 19007C allele compare to 19007T allele in smokers. More studies based on larger, stratified case-control population should be required to further evaluate the role of ERCC1 C8092A and T19007C polymorphisms in different cancer, especially in smokers.