Membrane proteins are essential components of many biochemical processes and are important pharmaceutical targets. Membrane protein structural biology provides the molecular rationale for these biochemical process as well as being a highly useful tool for drug discovery. Unfortunately, membrane protein structural biology is a difficult area of study due to low protein yields and high levels of instability especially when membrane proteins are removed from their native environments. Despite this instability, membrane protein structural biology has made great leaps over the last fifteen years. Today, the landscape is almost unrecognisable. The numbers of available atomic resolution structures have increased 10-fold though advances in crystallography and more recently by cryo-electron microscopy. These advances in structural biology were achieved through the efforts of many researchers around the world as well as initiatives such as the Membrane Protein Laboratory (MPL) at Diamond Light Source. The MPL has helped, provided access to and contributed to advances in protein production, sample preparation and data collection. Together, these advances have enabled higher resolution structures, from less material, at a greater rate, from a more diverse range of membrane protein targets. Despite this success, significant challenges remain. Here, we review the progress made and highlight current and future challenges that will be overcome.