Traditional fossil fuels, such as coal, oil, and natural gas, represent more than 85% of the global energy consumption. The excessive use of these traditional fossil fuels has brought environmental problems, such as air pollution and greenhouse effect. Hence, the search of sustainable and renewable energy is of significant importance. In view of the inexhaustible supply of water, hydrogen generation by water electrolysis is a promising strategy to provide sustainable energy source. One of the important factors that constrains the mass production of water electrolysis is lack of efficient and cost-effective catalysts. Thus, developing high efficiency, stable and low cost catalysts is highly desirable for the commercial H2 production from electrochemical/photoelectrochemical water splitting. In order to minimize the cost, non-noble metal based materials are substituting the costly and scarce noble metal materials. In this Thesis, we have investigated different types of transition metal based catalysts for water electrolysis/photoelectrolysis. The synthesis techniques, materials characterizations, and electrochemical/photoelectrochemical performance evaluation of the catalysts are presented in details. Four different catalysts are studied, which are (i) Co3S4 and Ni:Co3S4 nanowires, (ii) oxygen-deficient WO3 microplates, (iii) CoMo2S4 cross-linked porous nanoflakes, and (iv) hierarchical Cu(OH)2@Co(OH)2 nanotrees. We study the above catalysts from different aspects, from materials design, nanostructure engineering, to theoretic calculation. First, we start with transition metal oxide (Co3O4) nanowires and convert to Co3S4 for bifunctional electrocatalytic water splitting. Then we doped the nanowires with Ni elements to obtain Ni:Co3S4. In addition to systematic electrochemical characterization, DFT calculation is applied to determine the Gibbs free energy (ΔG) of the intermediates. It is found that the sulfur element reduces the ΔG of the intermediates and results in lower theoretic overpotential, leading to better HER and OER electrocatalytic performance