The development of Z-scheme heterojunctions has emerged as an effective approach for boosting the photocatalytic activity. Herein, we fabricated of a direct Z-scheme heterojunction between scaffold-like C3N4 and nanocylindrical Bi25FeO40, which exhibits enhanced photocatalytic activity and dye adsorption capacity. The in-situ embedding of Bi25FeO40 within scaffold C3N4 promotes photogenerated carrier separation, leading to an optimized degradation rate of 0.0205 min−1 and a contaminant removal efficiency of 85.3%. This work paves a new path for the development of high-efficiency photocatalytic degradation.