Cadmium sulphide quantum dots (CdS-QDs) were obtained by a precipitation method. Studies on the structural, optical and photocatalytic properties of undoped and metals (M = Fe, Ag, Zn) doped CdS were investigated. The structural properties of the metals composite CdS were analyzed using X-ray diffraction (XRD) and Infrared (IR) techniques. Optical properties of the composite materials were characterized by absorption and photoluminescence techniques. XRD pattern reveals the undoped and metals doped QDs have highly crystalline in nature with cubic phases. High transmission electron microscopy (TEM) shows the spherical shape of particles with approximately 3-4 nm in sizes. The crystallite sizes of CdS are increased with doping of metals but slightly different the sizes of XRD and TEM images. The band gap values of CdS, Fe:CdS, Ag:CdS, and Zn:CdS calculated by Tauc plot are predicted as 3.64, 3.50 eV, 3.43 and 3.35 eV respectively. Upon doping metals, shift in band gap of QDs toward the longer wavelength with the increases of crystallite sizes is observed and depends on type of metals. The emission peak of QDs is appeared at 521 nm along with a shoulder at 430 nm which confirms of cadmium vacancies in the lattice. The emission intensity of QDs is decreased when metals are included. The emission peaks of metals doped QDs are gradually decreased over the increasing irradiation time and influenced by the nature of metal. The photo-catalytic activity and efficiency degradation are dependent of metals which may due to different crystal quality in Ag, Fe and Zn into CdS QDs composite. Present results suggest that Zn:CdS composite enhanced with superior photo-degradation efficiency and photo-catalytic activity under the sunlight.