This paper examines how pre-service teachers of Portuguese developed ideas about contextually appropriate pedagogies during their practicum as well as what they perceived as the impact of their pedagogical practices on student learning. The findings suggest that teacher education models which promote conscious critical reflection and teacher agency, and provide space for trainees to engage constructively both with their peers and with students are likely to generate innovative ideas for teaching which are appropriate to the specific contexts within which trainees teach.