Photocatalytic hydrogen generation from water splitting has become a favorable route for the utilization of solar energy. An effective strategy, the combination of C-doping with nanocomposite semiconductors, is presented in this work. C-doped g-C3N4 (CCN) was prepared by supramolecular self-assembly and subsequently a number of CdIn2S4/CCN composite photocatalysts were designed and fabricated though in situ decoration of CdIn2S4 crystals on the surface of CCN nanosheets via a hydrothermal method. This unique architecture was able to efficiently promote the transfer and separation of photon-generated charges, enhance light absorption, and significantly increase photocatalytic H2 production. Detailed characterization was performed to analyze the crystal structure, morphology, elementary composition, optical properties and catalytic mechanism. The CdIn2S4/CCN nanocomposites with optimal CdIn2S4 content exhibited a maximum H2 production rate of 2985 μmol h−1 g−1, almost 15 times more than that obtained using pure g-C3N4 (205 μmol h−1 g−1). In addition, the hybrid photocatalysts display good recycling stability under visible-light irradiation. This research may provide promising information for the preparation of more efficient multifunctional hybrid photocatalysts with excellent stability in fine chemical engineering.